Merged
Conversation
jarzec
force-pushed
the
ci-fix-clang-18-compil-issue
branch
from
01499ac to
5d5e9e1
Compare
jarzec
commented
Nov 9, 2024
| -> bool | ||
| { | ||
| // Adopt this statement into our list of statements | ||
| statements.insert( |
Contributor
Author
There was a problem hiding this comment.
[Explanation] This call causes deletion of the std::unique_ptr<statement_node>. As discussed in #1088 this causes trouble for clang-18 if compound_statement_node::add_statement() is defiend before statement_node::~statement_node().
jarzec
force-pushed
the
ci-fix-clang-18-compil-issue
branch
from
5d5e9e1 to
9e1c305
Compare
jarzec
force-pushed
the
ci-fix-clang-18-compil-issue
branch
from
9e1c305 to
8e7c99b
Compare
Contributor
Author
|
I've rebased the branch on current main. |
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the definition of
compound_statement_node::add_statement()after the definition ofstatement_node::~statement_node()to fix compilation issue with clang-18.Together with #1336 this PR makes all the tests pass on CI.